visualize editor should not show if embed is set to true in url (elas…

…tic#16310)
ppisljar · Jan 29, 2018 · 1e0b259 · 1e0b259
1 parent 74f4f45
commit 1e0b259
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/src/core_plugins/kibana/public/visualize/editor/editor.html b/src/core_plugins/kibana/public/visualize/editor/editor.html
@@ -64,7 +64,7 @@
     saved-obj="savedVis"
     ui-state="uiState"
     app-state="state"
-    editor-mode="true"
+    editor-mode="chrome.getVisible()"
     show-spy-panel="chrome.getVisible()"
     >
 

diff --git a/test/functional/apps/visualize/_area_chart.js b/test/functional/apps/visualize/_area_chart.js
@@ -2,6 +2,7 @@ import expect from 'expect.js';
 
 export default function ({ getService, getPageObjects }) {
   const log = getService('log');
+  const remote = getService('remote');
   const retry = getService('retry');
   const PageObjects = getPageObjects(['common', 'visualize', 'header', 'settings']);
 
@@ -181,6 +182,15 @@ export default function ({ getService, getPageObjects }) {
             expect(data.trim().split('\n')).to.eql(expectedTableData);
           });
       });
+
+      it('should hide side editor if embed is set to true in url', async () => {
+        const url = await remote.getCurrentUrl();
+        const embedUrl = url.split('/visualize/').pop().replace('?_g=', '?embed=true&_g=');
+        await PageObjects.common.navigateToUrl('visualize', embedUrl);
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        const sideEditorExists = await PageObjects.visualize.getSideEditorExists();
+        expect(sideEditorExists).to.be(false);
+      });
     });
   });
 }
diff --git a/test/functional/page_objects/visualize_page.js b/test/functional/page_objects/visualize_page.js
@@ -261,6 +261,10 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
       return await testSubjects.exists('spyToggleButton');
     }
 
+    async getSideEditorExists() {
+      return await find.existsByCssSelector('.collapsible-sidebar');
+    }
+
     async openSpyPanel() {
       log.debug('openSpyPanel');
       const isOpen = await testSubjects.exists('spyContentContainer');