Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update capi-ibmcloud jobs with new release v0.7.0 #435

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Update capi-ibmcloud jobs with new release v0.7.0 #435

merged 1 commit into from
Dec 15, 2023

Conversation

Amulyam24
Copy link
Contributor

This PR updates capi-ibmcloud jobs with new release v0.7.0 and updates the kubekins-e2e image versions accordingly.

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 15, 2023
mkumatag
mkumatag approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2023
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 21958e0 into ppc64le-cloud:master Dec 15, 2023
3 checks passed
@ppc64le-cloud-bot
Copy link
Contributor

@Amulyam24: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key test-e2e-capi-ibmcloud-periodics.yaml using file config/jobs/periodic/cluster-api-provider-ibmcloud/test-e2e-capi-ibmcloud-periodics.yaml

In response to this:

This PR updates capi-ibmcloud jobs with new release v0.7.0 and updates the kubekins-e2e image versions accordingly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Prajyot-Parab
Prajyot-Parab reviewed Dec 15, 2023
View reviewed changes
config/jobs/periodic/cluster-api-provider-ibmcloud/test-e2e-capi-ibmcloud-periodics.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 162 - 18d3973#diff-19861b0f54e5f07a1d2a8f07d8d77a54d665c6af39c5621ee2dadc0fb297d2caR162 "vpc"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amulyam24 ^^^ please raise a PR for above change 0.7 release of vpc job must point to new template name.

@mkumatag mkumatag mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab left review comments

@mkumatag mkumatag mkumatag approved these changes

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Amulyam24 @ppc64le-cloud-bot @mkumatag @Prajyot-Parab