Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vpc e2e flavor #362

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Update vpc e2e flavor #362

merged 1 commit into from
Jan 25, 2023

Conversation

Prajyot-Parab
Copy link
Contributor

Signed-off-by: Prajyot-Parab [email protected]

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2023
@Prajyot-Parab
Copy link
Contributor Author

/cc @Amulyam24

@mkumatag
Copy link
Member

waiting on kubernetes-sigs/cluster-api-provider-ibmcloud#1043 to merge

@Amulyam24
Copy link
Contributor

Boskos cleanup for VPC doesn't yet handle cleanup for load balancers. Would be good to have that before we merge this PR. I can raise a PR by EOD if that's okay.

@Prajyot-Parab
Copy link
Contributor Author

/hold

@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2023
@Prajyot-Parab
Update e2e flavors
960a409 
Signed-off-by: Prajyot-Parab <[email protected]>
@Prajyot-Parab
Copy link
Contributor Author

/unhold

@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2023
@Prajyot-Parab
Copy link
Contributor Author

@mkumatag @Amulyam24 this one can be merged now

mkumatag
mkumatag approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2023
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2023
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit b7db9ef into ppc64le-cloud:master Jan 25, 2023
@ppc64le-cloud-bot
Copy link
Contributor

@Prajyot-Parab: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key test-e2e-capi-ibmcloud-periodics.yaml using file config/jobs/periodic/cluster-api-provider-ibmcloud/test-e2e-capi-ibmcloud-periodics.yaml

In response to this:

Signed-off-by: Prajyot-Parab [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@Rajalakshmi-Girish Rajalakshmi-Girish Awaiting requested review from Rajalakshmi-Girish

@Amulyam24 Amulyam24 Awaiting requested review from Amulyam24

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Prajyot-Parab @mkumatag @Amulyam24 @ppc64le-cloud-bot