Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chennai region and zones and update SysTypes #15

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Add Chennai region and zones and update SysTypes #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions region.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ func GetRegion(zone string) (region string, err error) {
region = "sao"
case strings.HasPrefix(zone, "us-east"):
region = "us-east"
case strings.HasPrefix(zone, "tor"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this removed? I still see an entry here for tor - https://cloud.ibm.com/docs/power-iaas?topic=power-iaas-ibm-cloud-reg

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prajyot-Parab @dharaneeshvrd @Karthik-K-N am I missing something here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a dup entry, that's why she removed I guess.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah two entries were there for tor, so I have removed one

region = "tor"
case strings.HasPrefix(zone, "eu-de-"):
region = "eu-de"
case strings.HasPrefix(zone, "lon"):
Expand All @@ -36,6 +34,8 @@ func GetRegion(zone string) (region string, err error) {
region = "wdc"
case strings.HasPrefix(zone, "tor"):
region = "tor"
case strings.HasPrefix(zone, "che"):
region = "che"
default:
return "", fmt.Errorf("region not found for the zone, talk to the developer to add the support into the tool: %s", zone)
}
Expand Down Expand Up @@ -95,7 +95,7 @@ var Regions = map[string]Region{
"mad02",
"mad04",
},
SysTypes: []string{"s1022"},
SysTypes: []string{"s1022", "e980"},
VPCZones: []string{"eu-es-1", "eu-es-2", "eu-es-3"},
},
"mon": {
Expand Down Expand Up @@ -141,7 +141,7 @@ var Regions = map[string]Region{
VPCRegion: "jp-tok",
COSRegion: "jp-tok",
Zones: []string{"tok04"},
SysTypes: []string{"s922", "e980"},
SysTypes: []string{"s922", "e980", "s1022"},
VPCZones: []string{"jp-tok-1", "jp-tok-2", "jp-tok-3"},
},
"tor": {
Expand All @@ -167,7 +167,7 @@ var Regions = map[string]Region{
Zones: []string{
"us-south",
},
SysTypes: []string{"s922", "e980"},
SysTypes: []string{"s922", "e980", "e880"},
VPCZones: []string{"us-south-1", "us-south-2", "us-south-3"},
},
"wdc": {
Expand All @@ -181,6 +181,16 @@ var Regions = map[string]Region{
SysTypes: []string{"s922", "e980"},
VPCZones: []string{"us-east-1", "us-east-2", "us-east-3"},
},
"che": {
Description: "Chennai, India",
VPCRegion: "",
COSRegion: "",
Zones: []string{
"che01",
},
SysTypes: []string{"s922", "e980"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope you have validated the sys types available in Chennai! If not you can check via PowerVS workspace in cloud.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the machine types for this zone che01 I can see only these two machine types

Do we need to include Dedicated host types as well in sysTypes ?

VPCZones: []string{},
},
}

// COSRegionForVPCRegion returns the corresponding COS region for the given VPC region
Expand Down
6 changes: 6 additions & 0 deletions region_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,12 @@ func TestGetRegion(t *testing.T) {
"mad",
false,
},
{
"Chennai",
args{"che01"},
"che",
false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down