Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a perf-based benchmark #92

Merged
merged 2 commits into from
Dec 21, 2018
Merged

Add a perf-based benchmark #92

merged 2 commits into from
Dec 21, 2018

Conversation

nbraud
Copy link
Collaborator

@nbraud nbraud commented Dec 14, 2018

First step towards #90. Depends on #91

@nbraud
Copy link
Collaborator Author

nbraud commented Dec 20, 2018

Is there anything that needs to be done for this PR to be mergeable?

@AstraLuma
Copy link
Member

I guess my only question is, how should this be used?

@nbraud
Copy link
Collaborator Author

nbraud commented Dec 21, 2018

@astronouth7303 I don't think this needs to be a full solution to #90 ?
Just having the ability to benchmark and compare is pretty useful, since it means we can easily check what's the performance impact of any given change (rather than me inventing a microbenchmark).

Moreover, the maintenance cost is negligible, since it's a script with less than 20 lines, which nothing depends on, and which doesn't need updating when adding new functions in Vector2 (thanks to tests.utils.*_OPS).

@AstraLuma AstraLuma merged commit a2a9262 into ppb:master Dec 21, 2018
@nbraud nbraud deleted the benchmark branch December 21, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants