-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve rotation stability #89
Conversation
PS: There's probably a performance hit in |
Can you categorize the performance hit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these are non-functional stylistic changes.
@astronouth7303 I think the commit whose style you find problematic is 5def680 ; it moved imports to ensure trig functions aren't used directly outside of |
PS: Tell me when the review is OK, and I will clean up the history. |
That is the big one, although |
Yeah, I did that change too. |
04c2dd5
to
219e874
Compare
OK, this is rebased & cleaned up |
Re: performance hit, I ran a pretty basic test ( I don't think we should care about a <1μs slowdown, even though that's 52% slower, considering that it gives less surprising results. PS: Updated to use the |
What's the blocker on this? |
Unrelated CI failure, due to a missing |
This solves an issue exposed in ppb#87, where imprecisions results in non-null components where the user would expect 0, for instance: >>> Vector2(1, 0).rotate(90) Vector2(6.123233995736766e-17, 1.0)
Otherwise, Hypothesis tests it with very large loop values, slowing down the entire testsuite, and triggering a warning.
f2e7762
to
152c9ab
Compare
cos
andsin
, solves precision issue from Improve the Readme #87.