-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sphincs-based documentation #130
Conversation
Also, remove the useless Table of Contents
Add the docstrings work to the Sphinx branch
…rtant to this type
…em)" This reverts commit f9260e4.
@astronouth7303 What do you think of d51a958 ? |
Ehhh... I'm not sure it's less awkward, but it's less-complicated terms? idk. |
@astronouth7303 Part of the point is that not all methods return |
All tests and lint tasks, except for CPython 3.8-rc. `docs` will need to be added once #130 lands.
@pathunstrom Do you think you will have time to review this, or should @astronouth7303 and I go ahead and merge? |
author = 'Piper Thunstrom, Jamie Bliss' | ||
|
||
# The short X.Y version | ||
version = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this autofilled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not as far as I know? I'm also not sure where it's used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not happy with the output around the magic methods, but until we find a solution that is nicer, this is good enough.
bors r=pathunstrom |
130: Add Sphincs-based documentation r=pathunstrom a=nbraud Closes #109 Co-authored-by: Jamie Bliss <[email protected]> Co-authored-by: Nicolas Braud-Santoni <[email protected]>
@astronouth7303 Looks like Travis CI picked up on Bors' temporary branch, failed to clone them due to a race-condition (Bors deleted the temp branch before Travis could clone it), and marked the PR as failing as a result; do you think this is worth fixing? |
Didn't we try to keep Travis from running against the tmp branches? |
@pathunstrom Nope, I forgot about Travis in #135 ;_; |
Build succeeded
|
This took a while because the Windows tasks all timed out waiting to start (after 15 minutes) the first time around; I guess Cirrus is having issues with their Windows boxes? |
Better it wastes time on an unwatched server than one of our machines. I think I like this bors process, even if I've not initiated it yet. |
Yes, I find it pretty convenient, since one can just tell it to merge and it will notify once CI is done on the merge commit, and push the merge (if CI is green), rather than having a human waiting on CI :) |
Closes #109