Fix non-linear shunt compensator section number #900
+49
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
For non-linear shunt compensators, the first section in
get_non_linear_shunt_compensator_sections
andupdate_non_linear_shunt_compensator_sections
is assumed to be 0 in the dataframe.This offset is confusing, e.g. for Entsoe's MicroGrid T4 (CGMES_v2.4.15_MicroGridTestConfiguration_T4_Assembled_BB_Complete_v2.zip), we get a
max_section_count
of 5 and the list of sections is 0...4. Updating section 5 values results in an error.Note that in
update_shunt_compensators
settingsection_count
works OK: 0 means disconnected.What is the new behavior (if this is a feature change)?
As per powsybl-core documentation, first section should be 1 // 0 meaning shunt disconnected.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: