Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CRAC utils classes that are not used (CracCleaningFeature and UcteNodeMatchingRule) #985

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

bqth29
Copy link
Collaborator

@bqth29 bqth29 commented Apr 25, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What is the new behavior (if this is a feature change)?
Two classes (CracCleaningFeature and UcteNodeMatchingRule) were not used and were removed.

Signed-off-by: Thomas Bouquet <[email protected]>
@bqth29 bqth29 changed the title Remove CRAC utils classes that are not used Remove CRAC utils classes that are not used (CracCleaningFeature and UcteNodeMatchingRule) Apr 25, 2024
@bqth29 bqth29 requested a review from pet-mit April 25, 2024 11:46
@bqth29 bqth29 added cleaning This issue or pull request only concerns improving the overall state of the code PR: waiting-for-review This PR is waiting to be reviewed labels Apr 25, 2024
@pet-mit pet-mit merged commit 76bbf76 into main Apr 25, 2024
9 checks passed
@pet-mit pet-mit deleted the remove_unused_classes branch April 25, 2024 12:30
MartinBelthle pushed a commit that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning This issue or pull request only concerns improving the overall state of the code PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants