Accelerate state tree init #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Edwards <[email protected]>
Signed-off-by: Philippe Edwards <[email protected]>
Signed-off-by: Philippe Edwards <[email protected]>
phiedw
added
PR: waiting-for-review
bqth29
previously approved these changes
Apr 24, 2024
Signed-off-by: Philippe Edwards <[email protected]>
…bl/open-rao into accelerate_state_tree_init
Signed-off-by: Philippe Edwards <[email protected]>
bqth29
approved these changes
Apr 24, 2024
MartinBelthle
pushed a commit
that referenced
this pull request
Apr 25, 2024
* precompute usage methods per state and instant in abstractRemedialAction Signed-off-by: Philippe Edwards <[email protected]> * cleaned up code Signed-off-by: Philippe Edwards <[email protected]> * revert changes to pom Signed-off-by: Philippe Edwards <[email protected]> * added tests Signed-off-by: Philippe Edwards <[email protected]> * fix tests Signed-off-by: Philippe Edwards <[email protected]> --------- Signed-off-by: Philippe Edwards <[email protected]> Co-authored-by: Philippe Edwards <[email protected]> Signed-off-by: belthlemar <[email protected]>
3 tasks
pet-mit
pushed a commit
that referenced
this pull request
May 2, 2024
MartinBelthle
pushed a commit
that referenced
this pull request
May 28, 2024
* precompute usage methods per state and instant in abstractRemedialAction Signed-off-by: Philippe Edwards <[email protected]> * cleaned up code Signed-off-by: Philippe Edwards <[email protected]> * revert changes to pom Signed-off-by: Philippe Edwards <[email protected]> * added tests Signed-off-by: Philippe Edwards <[email protected]> * fix tests Signed-off-by: Philippe Edwards <[email protected]> --------- Signed-off-by: Philippe Edwards <[email protected]> Co-authored-by: Philippe Edwards <[email protected]> Signed-off-by: belthlemar <[email protected]>
MartinBelthle
pushed a commit
that referenced
this pull request
May 28, 2024
Signed-off-by: belthlemar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Performance
What is the current behavior?
Remedial actions have to go through all the usage rules it has every time we want to check if it's available for a state, making state tree creation very slow in some cases.
What is the new behavior (if this is a feature change)?
Remedial actions now go through all the usage rules once and stores info to accelerate next time we want to check availability, making state tree much much faster.
Does this PR introduce a breaking change or deprecate an API?