Make contingency order deterministic for sensitivity computation #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Edwards <[email protected]>
Signed-off-by: Philippe Edwards <[email protected]>
phiedw
added
the
next-release
pet-mit
approved these changes
Apr 4, 2024
… into fixed_sensi_order
MartinBelthle
pushed a commit
that referenced
this pull request
Apr 25, 2024
* use id to fix the order of contingencies in sensitivity computation Signed-off-by: Philippe Edwards <[email protected]> Signed-off-by: belthlemar <[email protected]>
MartinBelthle
pushed a commit
that referenced
this pull request
May 28, 2024
* use id to fix the order of contingencies in sensitivity computation Signed-off-by: Philippe Edwards <[email protected]> Signed-off-by: belthlemar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix?
What is the current behavior?
The order of contingencies for loadflow is very unstable (even changing a logback file can change it). This can change the results of OLF by very small values.
What is the new behavior (if this is a feature change)?
The contingencies are ordered by their id.
Does this PR introduce a breaking change or deprecate an API?