-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSA] Multiple TATLs and 3 curatives instants #958
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
# Conflicts: # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/remedialaction/CsaProfileRemedialActionsCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/parameters/CsaCracCreationParameters.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/parameters/JsonCsaCracCreationParameters.java # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/parameters/JsonCsaCracCreationParametersTest.java # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/remedialaction/PstRangeActionCreationTest.java
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
# Conflicts: # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/CsaProfileSsiTest.java
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
# Conflicts: # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/remedialaction/CsaProfileRemedialActionsCreator.java
# Conflicts: # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/CsaProfileCnecCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/FlowCnecCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/remedialaction/CsaProfileRemedialActionsCreator.java
Signed-off-by: Thomas Bouquet <[email protected]>
jipea
reviewed
Apr 23, 2024
.../powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/AngleCnecCreator.java
Show resolved
Hide resolved
...ybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/FlowCnecInstantHelper.java
Show resolved
Hide resolved
jipea
previously approved these changes
Apr 25, 2024
miam les conflits |
# Conflicts: # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/CsaProfileCracCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/CsaProfileCnecCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/FlowCnecCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/remedialaction/CsaProfileRemedialActionsCreator.java # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/AngleCnecCreationTest.java # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/FlowCnecCreationTest.java # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/VoltageCnecCreationTest.java # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/remedialaction/GroupRemedialActionTest.java # data/crac-creation/crac-creator-csa-profiles/src/test/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/remedialaction/RemedialActionCreationTest.java
Signed-off-by: Thomas Bouquet <[email protected]>
# Conflicts: # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/CsaProfileCracCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/CsaProfileCnecCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/FlowCnecCreator.java # data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/remedialaction/CsaProfileRemedialActionsCreator.java
Signed-off-by: Thomas Bouquet <[email protected]>
bqth29
changed the title
Multiple TATLs and 3 curatives instants
[CSA] Multiple TATLs and 3 curatives instants
May 15, 2024
phiedw
approved these changes
May 23, 2024
...m/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/FlowCnecCreator.java
Show resolved
Hide resolved
...m/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/FlowCnecCreator.java
Outdated
Show resolved
Hide resolved
...ybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/FlowCnecInstantHelper.java
Outdated
Show resolved
Hide resolved
...ybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/FlowCnecInstantHelper.java
Outdated
Show resolved
Hide resolved
phiedw
requested changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
misclicked last review
phiedw
added
PR: waiting-for-correction
This PR is waiting to be corrected by its author
and removed
PR: waiting-for-review
This PR is waiting to be reviewed
labels
May 23, 2024
Signed-off-by: Thomas Bouquet <[email protected]>
phiedw
approved these changes
May 24, 2024
MartinBelthle
pushed a commit
that referenced
this pull request
May 28, 2024
* Create CSA CRAC with 3 curatives instants Signed-off-by: Thomas Bouquet <[email protected]> * Fix instants check for onConstraints URs Signed-off-by: Thomas Bouquet <[email protected]> * Update CRAC creation parameters Signed-off-by: Thomas Bouquet <[email protected]> * Create FlowCnecInstantHelper + check CRAC creation parameters Signed-off-by: Thomas Bouquet <[email protected]> * Association algorithm draft Signed-off-by: Thomas Bouquet <[email protected]> * Update with new main commits Signed-off-by: Thomas Bouquet <[email protected]> * Tests for association map Signed-off-by: Thomas Bouquet <[email protected]> * Add TODOs Signed-off-by: Thomas Bouquet <[email protected]> * Handle limits durations not in map Signed-off-by: Thomas Bouquet <[email protected]> * Create on CNEC per side Signed-off-by: Thomas Bouquet <[email protected]> * New FlowCNEC instant association Signed-off-by: Thomas Bouquet <[email protected]> * Log in context when branch has not TATL but PATL should not be used Signed-off-by: Thomas Bouquet <[email protected]> * Remove useless comment Signed-off-by: Thomas Bouquet <[email protected]> * Refactor FlowCnecCreator Signed-off-by: Thomas Bouquet <[email protected]> * Doc for TATLs Signed-off-by: Thomas Bouquet <[email protected]> * Doc for TATLs (more detailed) Signed-off-by: Thomas Bouquet <[email protected]> * Update doc for import Signed-off-by: Thomas Bouquet <[email protected]> * Better TATL graphs Signed-off-by: Thomas Bouquet <[email protected]> * Better no TATL 600 graph Signed-off-by: Thomas Bouquet <[email protected]> * TATL 600 Signed-off-by: Thomas Bouquet <[email protected]> * Fix import bug on groups Signed-off-by: Thomas Bouquet <[email protected]> * Fix after merge Signed-off-by: Thomas Bouquet <[email protected]> * Merge main Signed-off-by: Thomas Bouquet <[email protected]> * Merge main Signed-off-by: Thomas Bouquet <[email protected]> * Fix after comments Signed-off-by: Thomas Bouquet <[email protected]> --------- Signed-off-by: Thomas Bouquet <[email protected]> Co-authored-by: phiedw <[email protected]> Signed-off-by: belthlemar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
New feature or request
PR: waiting-for-correction
This PR is waiting to be corrected by its author
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
FlowCnecInstantHelper
Does this PR introduce a breaking change or deprecate an API?
Other information:
Small refactoring of the
FlowCnecCreator
class.