feat(optimization): re-optimize some PSTs in second preventive #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBelthle
force-pushed
the
feat/optimize-more-RAs-in-second-prev
branch
from
12ea1d5 to
4e338b2
Compare
MartinBelthle
changed the title
MartinBelthle
force-pushed
the
feat/optimize-more-RAs-in-second-prev
branch
3 times, most recently
from
9bb1d50 to
d999c04
Compare
MartinBelthle
force-pushed
the
feat/optimize-more-RAs-in-second-prev
branch
4 times, most recently
from
1484910 to
16c3760
Compare
phiedw
requested changes
Mar 26, 2024
...src/main/java/com/powsybl/openrao/searchtreerao/castor/algorithm/CastorFullOptimization.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/powsybl/openrao/searchtreerao/castor/algorithm/CastorFullOptimization.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/powsybl/openrao/searchtreerao/castor/algorithm/CastorFullOptimization.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/powsybl/openrao/searchtreerao/castor/algorithm/CastorFullOptimization.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/powsybl/openrao/searchtreerao/castor/algorithm/CastorFullOptimization.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/powsybl/openrao/searchtreerao/castor/algorithm/CastorFullOptimization.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/powsybl/openrao/searchtreerao/castor/algorithm/CastorFullOptimization.java
Outdated
Show resolved
Hide resolved
MartinBelthle
force-pushed
the
feat/optimize-more-RAs-in-second-prev
branch
from
5d44be0 to
06c172a
Compare
MartinBelthle
added
PR: waiting-for-review
phiedw
requested changes
Mar 26, 2024
...src/main/java/com/powsybl/openrao/searchtreerao/castor/algorithm/CastorFullOptimization.java
Outdated
Show resolved
Hide resolved
phiedw
requested changes
Mar 27, 2024
...src/main/java/com/powsybl/openrao/searchtreerao/castor/algorithm/CastorFullOptimization.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/powsybl/openrao/searchtreerao/castor/algorithm/CastorFullOptimization.java
Outdated
Show resolved
Hide resolved
pet-mit
added
bug
MartinBelthle
force-pushed
the
feat/optimize-more-RAs-in-second-prev
branch
from
3afd041 to
41676d7
Compare
MartinBelthle
force-pushed
the
feat/optimize-more-RAs-in-second-prev
branch
from
5661ca2 to
d411e9d
Compare
phiedw
requested changes
May 22, 2024
| .collect(Collectors.toSet()); | ||
|
|
||
| // If first preventive diverged, we want to remove every range action that is both preventive and auto or curative. |
There was a problem hiding this comment.
Why do we want to do this?
There was a problem hiding this comment.
If the 1st preventive diverges, I can't get any RAs setpoint for this state and therefore I can't compare taps to know if raUsageLimits are at risk.
Considering this, i chose to take no risk and remove every RA available for multiple instants.
Perhaps there's another way to do it and if so, do not hesitate to comment it
There was a problem hiding this comment.
That seems the safest thing to do indeed. Do you know if there is a test case that runs a full RAO with a skipped first preventive? (I'm curious what happens in that case in the rest of the algorithm)
...src/main/java/com/powsybl/openrao/searchtreerao/castor/algorithm/CastorFullOptimization.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/powsybl/openrao/searchtreerao/castor/algorithm/CastorFullOptimization.java
Show resolved
Hide resolved
phiedw
added
PR: waiting-for-correction
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
MartinBelthle
force-pushed
the
feat/optimize-more-RAs-in-second-prev
branch
from
d411e9d to
6e8e28e
Compare
Signed-off-by: belthlemar <[email protected]>
MartinBelthle
added
PR: waiting-for-review
phiedw
approved these changes
May 30, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #894
Other information
This PR is linked with another PR with added doc: farao-community/farao-community.github.io#117.
Every test on cucumber main branch passed.