Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #923

Merged
merged 16 commits into from
Mar 21, 2024
Merged

Refactor tests #923

merged 16 commits into from
Mar 21, 2024

Conversation

bqth29
Copy link
Collaborator

@bqth29 bqth29 commented Mar 20, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • CSA CRAC import tests were refactored to use less files and and common network (faster)
  • CurrentLimit and VoltageLimit queries were updated to match the latest CGMES version
  • Import details for not imported CNECs, contingencies or remedial actions were made more homogeneous

bqth29 added 15 commits March 15, 2024 14:03
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
@bqth29 bqth29 requested review from jipea and benrejebmoh March 20, 2024 14:34
Signed-off-by: Thomas Bouquet <[email protected]>
Copy link
Collaborator

@benrejebmoh benrejebmoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think that you have a different indents configuration from the rest of the team, which can make it harder for review

@jipea jipea merged commit 7b18f2f into main Mar 21, 2024
6 checks passed
@pet-mit pet-mit deleted the fix/csa_operational_limits branch April 4, 2024 15:20
MartinBelthle pushed a commit that referenced this pull request May 28, 2024
* Add graph dependency for network elementary actions queries

Signed-off-by: Thomas Bouquet <[email protected]>

* inBaseCase + TATL = only one CNEC

Signed-off-by: Thomas Bouquet <[email protected]>

* Refactor contingencies import messages

Signed-off-by: Thomas Bouquet <[email protected]>

* Angle and Voltage CNECs + remove TC1&TC2

Signed-off-by: Thomas Bouquet <[email protected]>

* PstRangeActions tests

Signed-off-by: Thomas Bouquet <[email protected]>

* Injection setpoint actions tests

Signed-off-by: Thomas Bouquet <[email protected]>

* Remedial actions tests

Signed-off-by: Thomas Bouquet <[email protected]>

* Remove useless files

Signed-off-by: Thomas Bouquet <[email protected]>

* Remedial action groups tests

Signed-off-by: Thomas Bouquet <[email protected]>

* Fix tests

Signed-off-by: Thomas Bouquet <[email protected]>

* rename operational limits query fields

Signed-off-by: Thomas Bouquet <[email protected]>

* VoltageCNECs tests with Equipments and Terminals

Signed-off-by: Thomas Bouquet <[email protected]>

* Revert query for CurrentLimits

Signed-off-by: Thomas Bouquet <[email protected]>

* Codestyle

Signed-off-by: Thomas Bouquet <[email protected]>

* Only use Equipment in VoltageCnec query

Signed-off-by: Thomas Bouquet <[email protected]>

* Remove useless methods in utils

Signed-off-by: Thomas Bouquet <[email protected]>

---------

Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants