Parallelize network cloning #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Mitri <[email protected]>
Signed-off-by: Peter Mitri <[email protected]>
Signed-off-by: Peter Mitri <[email protected]>
phiedw
approved these changes
Mar 4, 2024
MartinBelthle
pushed a commit
that referenced
this pull request
May 28, 2024
Signed-off-by: belthlemar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Performance improvement
What is the current behavior?
When parallelizing contingency computations or network actions in search tree, the network pool starts by cloning the network for it to be used by multiple threads. These clones are created in the main thread, and cloning a big network can be slow. Thus we need to wait N x the time to clone one network (N being the number of computation threads).
What is the new behavior (if this is a feature change)?
The clones are now created on the N threads in parallel, thus dividing this wait time by N.
Does this PR introduce a breaking change or deprecate an API?