Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csa profiles groups and dependencies #889

Merged
merged 9 commits into from
Feb 23, 2024
Merged

csa profiles groups and dependencies #889

merged 9 commits into from
Feb 23, 2024

Conversation

benrejebmoh
Copy link
Collaborator

…sign

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

# Conflicts:
#	data/crac-creation/crac-creator-csa-profiles/src/main/java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/CsaProfileCracCreator.java
@benrejebmoh benrejebmoh added PR: waiting-for-review This PR is waiting to be reviewed and removed PR: WIP labels Feb 23, 2024
@benrejebmoh benrejebmoh changed the title first version of csa groups and dependencies -> goal is to discuss de… csa profiles groups and dependencies Feb 23, 2024
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh benrejebmoh merged commit e2d918d into main Feb 23, 2024
6 checks passed
@benrejebmoh benrejebmoh deleted the csa-groups branch February 23, 2024 15:09
MartinBelthle pushed a commit that referenced this pull request May 28, 2024
* first version of csa groups and dependencies -> goal is to discuss design

Signed-off-by: benrejebmoh <[email protected]>

* merge with master and fix cast issue

Signed-off-by: benrejebmoh <[email protected]>

* csa-groups and dependencies + first 2 unit tests of us

Signed-off-by: benrejebmoh <[email protected]>

* csa-groups and dependencies with ssi impl and test

Signed-off-by: benrejebmoh <[email protected]>

* csa-profiles: use propertybag.getId instead of substring to get id

Signed-off-by: benrejebmoh <[email protected]>

* csa-profiles: fix case when several TapPositionActions are linked to the same GridStateAlterationRemedialAction

Signed-off-by: benrejebmoh <[email protected]>

* enhancements after review

Signed-off-by: benrejebmoh <[email protected]>

---------

Signed-off-by: benrejebmoh <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants