Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move virtual-hubs to farao-core #851

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Move virtual-hubs to farao-core #851

merged 7 commits into from
Dec 18, 2023

Conversation

phiedw
Copy link
Collaborator

@phiedw phiedw commented Dec 12, 2023

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Migration of a repository

What is the current behavior? (You can also link to an open issue here)
farao-virtual-hubs has its own repo on github

What is the new behavior (if this is a feature change)?
It is now directly included in farao-core. Also some modules have been removed

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Not yet, but the farao-virtual-hubs should be deleted once everyone moves to farao-core

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@phiedw phiedw added the PR: waiting-for-review This PR is waiting to be reviewed label Dec 14, 2023
OpenSuze
OpenSuze previously approved these changes Dec 15, 2023
data/pom.xml Outdated Show resolved Hide resolved
data/virtual-hubs/pom.xml Outdated Show resolved Hide resolved
data/virtual-hubs/virtual-hubs-api/pom.xml Outdated Show resolved Hide resolved
data/virtual-hubs/virtual-hubs-json/pom.xml Outdated Show resolved Hide resolved
data/virtual-hubs/virtual-hubs-network-assigner/pom.xml Outdated Show resolved Hide resolved
data/virtual-hubs/virtual-hubs-network-extension/pom.xml Outdated Show resolved Hide resolved
data/virtual-hubs/virtual-hubs-xml/pom.xml Outdated Show resolved Hide resolved
@phiedw phiedw merged commit c16c77d into master Dec 18, 2023
4 checks passed
@pet-mit pet-mit deleted the virtual_hubs_in_core branch January 8, 2024 15:38
MartinBelthle pushed a commit that referenced this pull request May 28, 2024
* moved virtual-hubs to farao-core

* cleaned up a pom

Signed-off-by: Philippe Edwards <[email protected]>

* added security around xml import of virtual hubs

* fixes after review

---------

Signed-off-by: Philippe Edwards <[email protected]>
Co-authored-by: OpenSuze <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants