-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move virtual-hubs to farao-core #851
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Edwards <[email protected]>
...c/main/java/com/farao_community/farao/virtual_hubs/xml/VirtualHubsConfigurationImporter.java
Show resolved
Hide resolved
OpenSuze
previously approved these changes
Dec 15, 2023
...l-hubs/virtual-hubs-api/src/main/java/com/farao_community/farao/virtual_hubs/MarketArea.java
Show resolved
Hide resolved
data/virtual-hubs/virtual-hubs-network-extension/src/main/resources/xsd/assignedVirtualHub.xsd
Outdated
Show resolved
Hide resolved
...c/main/java/com/farao_community/farao/virtual_hubs/xml/VirtualHubsConfigurationImporter.java
Show resolved
Hide resolved
OpenSuze
approved these changes
Dec 15, 2023
MartinBelthle
pushed a commit
that referenced
this pull request
May 28, 2024
* moved virtual-hubs to farao-core * cleaned up a pom Signed-off-by: Philippe Edwards <[email protected]> * added security around xml import of virtual hubs * fixes after review --------- Signed-off-by: Philippe Edwards <[email protected]> Co-authored-by: OpenSuze <[email protected]> Signed-off-by: belthlemar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Migration of a repository
What is the current behavior? (You can also link to an open issue here)
farao-virtual-hubs has its own repo on github
What is the new behavior (if this is a feature change)?
It is now directly included in farao-core. Also some modules have been removed
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Not yet, but the farao-virtual-hubs should be deleted once everyone moves to farao-core
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)