Enhance RaoResult with Monitoring results #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pet-mit
requested changes
Nov 22, 2023
...-api/src/main/java/com/farao_community/farao/data/rao_result_api/AbstractRaoResultClone.java
Outdated
Show resolved
Hide resolved
...-api/src/main/java/com/farao_community/farao/data/rao_result_api/AbstractRaoResultClone.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/com/farao_community/farao/monitoring/angle_monitoring/AngleMonitoring.java
Outdated
Show resolved
Hide resolved
...java/com/farao_community/farao/monitoring/angle_monitoring/RaoResultWithAngleMonitoring.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/farao_community/farao/monitoring/angle_monitoring/AngleMonitoringTest.java
Outdated
Show resolved
Hide resolved
.../com/farao_community/farao/monitoring/voltage_monitoring/RaoResultWithVoltageMonitoring.java
Outdated
Show resolved
Hide resolved
.../com/farao_community/farao/monitoring/voltage_monitoring/RaoResultWithVoltageMonitoring.java
Outdated
Show resolved
Hide resolved
.../com/farao_community/farao/monitoring/voltage_monitoring/RaoResultWithVoltageMonitoring.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/farao_community/farao/monitoring/voltage_monitoring/VoltageMonitoring.java
Show resolved
Hide resolved
...test/java/com/farao_community/farao/monitoring/voltage_monitoring/VoltageMonitoringTest.java
Outdated
Show resolved
Hide resolved
pet-mit
requested changes
Nov 23, 2023
...o-result-api/src/main/java/com/farao_community/farao/data/rao_result_api/RaoResultClone.java
Outdated
Show resolved
Hide resolved
...sult-api/src/test/java/com/farao_community/farao/data/rao_result_api/RaoResultCloneTest.java
Outdated
Show resolved
Hide resolved
...java/com/farao_community/farao/monitoring/angle_monitoring/RaoResultWithAngleMonitoring.java
Outdated
Show resolved
Hide resolved
pet-mit
approved these changes
Nov 23, 2023
MartinBelthle
pushed a commit
that referenced
this pull request
May 28, 2024
* enhance RaoResult with Angle and Voltage Monitoring results * enhance RaoResult with Angle and Voltage Monitoring results * fix previous commit * enhance unit test of AbstractRaoResultClone.java * add test coverage for AbstractRaoResultClone.java * changes after review * changes after review * minor changes after second review Signed-off-by: belthlemar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)