Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csa/refactor/profile header check #820

Merged
merged 8 commits into from
Oct 20, 2023

Conversation

jipea
Copy link
Collaborator

@jipea jipea commented Oct 12, 2023

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@jipea jipea requested review from pet-mit and benrejebmoh October 12, 2023 13:38
@jipea jipea marked this pull request as ready for review October 20, 2023 12:28
@jipea jipea added the PR: waiting-for-review This PR is waiting to be reviewed label Oct 20, 2023
@benrejebmoh benrejebmoh merged commit f59b637 into master Oct 20, 2023
@benrejebmoh benrejebmoh deleted the csa/refactor/profile_header_check branch October 20, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants