Angle monitoring noglsk #1249
Open
Angle monitoring noglsk #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 23, 2024 16:22
Signed-off-by: CHEN Roxane <[email protected]>
Signed-off-by: CHEN Roxane <[email protected]>
Signed-off-by: CHEN Roxane <[email protected]>
|
Crash no matter what error occurs in the try (not just missing country code error) is it problematic? Are there cases where you just want to interrupt and still go to the end of the function? |
Godelaine
requested changes
Jan 6, 2025
monitoring/src/main/java/com/powsybl/openrao/monitoring/Monitoring.java
Outdated
Show resolved
Hide resolved
| @@ -140,6 +140,7 @@ public MonitoringResult runMonitoring(MonitoringInput monitoringInput, int numbe | |||
| networkPool.shutdownAndAwaitTermination(24, TimeUnit.HOURS); | |||
| } catch (Exception e) { | |||
| Thread.currentThread().interrupt(); | |||
| throw new OpenRaoException(e); | |||
There was a problem hiding this comment.
waiting on information for best way to proceed:
- crash, as you did, but we need to check that we didn't expect partial results for existing exception cases
- log error, sert result to failure
monitoring/src/main/java/com/powsybl/openrao/monitoring/Monitoring.java
Outdated
Show resolved
Hide resolved
monitoring/src/test/java/com/powsybl/openrao/monitoring/AngleMonitoringTest.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,71 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <GLSK_MarketDocument xsi:schemaLocation="urn:iec62325.351:tc57wg16:451-n:glskdocument:2:1 iec62325-451-n-glsk_v2_1.xsd" xmlns="urn:iec62325.351:tc57wg16:451-n:glskdocument:2:1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> | |||
There was a problem hiding this comment.
not necessary, since we want to test the absence of glsk
Godelaine
added
the
PR: waiting-for-info-author
Signed-off-by: CHEN Roxane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #1202
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: