Fix NPE in AutomatonPerimeterResultImpl #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esult to fix errors trying to fetch a result Signed-off-by: Philippe Edwards <[email protected]>
phiedw
added
bug
Signed-off-by: Godelaine de Montmorillon <[email protected]>
Godelaine
added
PR: waiting-for-correction
Godelaine
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
If the sensitivity fails initially for an automaton perimeter, the result for it will be DEFAULT because it checks the status of the sensitivityResult (which is the one post PRA so is DEFAULT as long as the N situation is ok). When building 2P inputs, there's then a crash when attempting to get setpoints in that result.
What is the new behavior (if this is a feature change)?
The status is now checked for the specific state, and when building 2P inputs, we skipt results that have a FAILURE status.
Does this PR introduce a breaking change or deprecate an API?
Other information:
Bug encountered in the SWE CC process.