Generify CSA CRAC Creation Parameters #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Bouquet <[email protected]>
bqth29
added
the
cleaning
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
# Conflicts: # data/crac/crac-io/crac-io-csa-profiles/src/test/resources/parameters/csa-crac-parameters-json-csa-crac-creation-parameters-test.json # data/crac/crac-io/crac-io-csa-profiles/src/test/resources/parameters/csa-crac-parameters-nok-1.json # data/crac/crac-io/crac-io-csa-profiles/src/test/resources/parameters/csa-crac-parameters-nok-2.json # data/crac/crac-io/crac-io-csa-profiles/src/test/resources/parameters/csa-crac-parameters-nok-3.json
Signed-off-by: Thomas Bouquet <[email protected]>
jipea
previously approved these changes
Oct 11, 2024
benrejebmoh
previously approved these changes
Oct 11, 2024
phiedw
reviewed
Oct 11, 2024
...java/com/powsybl/openrao/data/cracio/csaprofiles/craccreator/cnec/FlowCnecInstantHelper.java
Outdated
Show resolved
Hide resolved
...va/com/powsybl/openrao/data/cracio/csaprofiles/parameters/JsonCsaCracCreationParameters.java
Outdated
Show resolved
Hide resolved
...va/com/powsybl/openrao/data/cracio/csaprofiles/parameters/JsonCsaCracCreationParameters.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Bouquet <[email protected]>
jipea
approved these changes
Oct 15, 2024
phiedw
approved these changes
Oct 22, 2024
bqth29
added a commit
that referenced
this pull request
Nov 26, 2024
* Generify CSA CRAC Creation Parameters Signed-off-by: Thomas Bouquet <[email protected]> * Add curative instants in parameters Signed-off-by: Thomas Bouquet <[email protected]> * Create curative instants from crac creation parameters Signed-off-by: Thomas Bouquet <[email protected]> * add TODO Signed-off-by: Thomas Bouquet <[email protected]> * Merge main Signed-off-by: Thomas Bouquet <[email protected]> * Replace list of pair by map Signed-off-by: Thomas Bouquet <[email protected]> --------- Signed-off-by: Thomas Bouquet <[email protected]> Co-authored-by: benrejebmoh <[email protected]> Signed-off-by: Thomas Bouquet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #1153
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: