[CSA] No longer read AE.isCombinableWithRemedialAction attribute #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Bouquet <[email protected]>
bqth29
added
cleaning
Signed-off-by: Thomas Bouquet <[email protected]>
jipea
requested changes
Oct 16, 2024
.../main/java/com/powsybl/openrao/data/cracio/csaprofiles/craccreator/cnec/FlowCnecCreator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Bouquet <[email protected]>
jipea
previously approved these changes
Oct 17, 2024
Signed-off-by: Thomas Bouquet <[email protected]>
benrejebmoh
approved these changes
Oct 23, 2024
bqth29
added a commit
that referenced
this pull request
Nov 26, 2024
* No longer read attribute Signed-off-by: Thomas Bouquet <[email protected]> * Add geo filter Signed-off-by: Thomas Bouquet <[email protected]> * remove geographical filter Signed-off-by: Thomas Bouquet <[email protected]> * remove getBranchLocation Signed-off-by: Thomas Bouquet <[email protected]> * sonar Signed-off-by: Thomas Bouquet <[email protected]> --------- Signed-off-by: Thomas Bouquet <[email protected]> Co-authored-by: jipea <[email protected]> Signed-off-by: Thomas Bouquet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
The field isCombinableWithRemedialAction was making the CRAC heavier than needed by adding OnConstraint usage rules even though the behavior is already covered by other usage rules.
What kind of change does this PR introduce?
The attribute is no longer read which avoid creating several useless or undesired OnConstraint usage rules for remedial actions.