Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent exceptions due to Map in FlowResultImpl #1118

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

phiedw
Copy link
Collaborator

@phiedw phiedw commented Aug 28, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

An exception was sometimes thrown by FlowResultImpl when getting a result from the memoization map.

What is the new behavior (if this is a feature change)?
The HashMap has been replaced by a ConcurrentHashMap.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@phiedw phiedw added the PR: waiting-for-review This PR is waiting to be reviewed label Aug 30, 2024
@pet-mit pet-mit merged commit fe0e969 into main Aug 30, 2024
10 checks passed
@pet-mit pet-mit deleted the fix_concurrent_map_flow_result branch August 30, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants