Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FbConstraintDocument] Support new schema versions #1107

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

pet-mit
Copy link
Collaborator

@pet-mit pet-mit commented Aug 7, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Bug fix (?)

What is the current behavior?

OpenRAO can't automatically import newer versions of FbConstraintDocument (> 20).

What is the new behavior (if this is a feature change)?
FbConstraint version 18's XSD validator is now used to import all versions >= 17.
This is not ideal (we better have one xsd per version) but works for now in production processes.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@pet-mit pet-mit marked this pull request as ready for review August 7, 2024 13:01
@pet-mit pet-mit added PR: waiting-for-review This PR is waiting to be reviewed next-release This issue or pull request should be resolved before next release labels Aug 7, 2024
@pet-mit pet-mit requested a review from kahyami August 7, 2024 13:02
@pet-mit pet-mit merged commit a6074d0 into main Aug 9, 2024
10 checks passed
@pet-mit pet-mit deleted the fbconstraint_fix branch August 9, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release This issue or pull request should be resolved before next release PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants