Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete crac-creator package #1100

Merged
merged 9 commits into from
Aug 1, 2024
Merged

Delete crac-creator package #1100

merged 9 commits into from
Aug 1, 2024

Conversation

bqth29
Copy link
Collaborator

@bqth29 bqth29 commented Jul 31, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
Fixes #1080

What kind of change does this PR introduce?
Removed crac-creation package and moved its sub-packages to crac-io. Renamed all crac-creator-* to crac-io-*.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

bqth29 added 2 commits July 31, 2024 10:21
Signed-off-by: Thomas Bouquet <[email protected]>
Signed-off-by: Thomas Bouquet <[email protected]>
@bqth29 bqth29 marked this pull request as ready for review July 31, 2024 08:30
@bqth29 bqth29 added the cleaning This issue or pull request only concerns improving the overall state of the code label Jul 31, 2024
@bqth29 bqth29 requested a review from pet-mit July 31, 2024 08:30
data/crac-io/crac-io-api/pom.xml Outdated Show resolved Hide resolved
@bqth29 bqth29 requested a review from pet-mit August 1, 2024 07:42
@bqth29 bqth29 added PR: waiting-for-review This PR is waiting to be reviewed breaking-change Changes could break users' code labels Aug 1, 2024
@bqth29 bqth29 merged commit 6f0cc99 into main Aug 1, 2024
10 checks passed
@bqth29 bqth29 mentioned this pull request Aug 2, 2024
3 tasks
@bqth29 bqth29 deleted the remove-crac-creator branch October 23, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes could break users' code cleaning This issue or pull request only concerns improving the overall state of the code PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove crac-creation package
2 participants