Fix raoResult.isSecure(ANGLE) and raoResult.isSecure(VOLTAGE) #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Mitri <[email protected]>
pet-mit
added
bug
kahyami
approved these changes
Jul 31, 2024
bqth29
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When RaoResultWithAngleMonitoring is called with isSecure(ANGLE), it returns false if FLOW is unsecure, even though ANGLE is secure. This is due to the fact that it calls the underlying flowRaoResult.isSecure(physicalParams) with physicalParams being empty, which misbehaves.
Same thing happens for voltage monitoring.
What is the new behavior (if this is a feature change)?
The issue has been fixed by not calling the underlying raoResult.isSecure if physicalParams is empty
Does this PR introduce a breaking change or deprecate an API?