Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Generify voltage and angle monitoring #1092

Merged
merged 53 commits into from
Oct 10, 2024
Merged

[Monitoring] Generify voltage and angle monitoring #1092

merged 53 commits into from
Oct 10, 2024

Conversation

benrejebmoh
Copy link
Collaborator

@benrejebmoh benrejebmoh commented Jul 15, 2024 •
edited by pet-mit
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #899

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@pet-mit pet-mit mentioned this pull request Jul 15, 2024
Closed
5 tasks
pet-mit
pet-mit reviewed Jul 18, 2024
View reviewed changes
generic-monitoring/pom.xml Outdated Show resolved Hide resolved
pet-mit
pet-mit requested changes Jul 18, 2024
View reviewed changes
generic-monitoring/src/main/java/com/powsybl/openrao/monitoring/MonitoringInput.java Outdated Show resolved Hide resolved
generic-monitoring/src/main/java/com/powsybl/openrao/monitoring/Monitoring.java Outdated Show resolved Hide resolved
generic-monitoring/src/main/java/com/powsybl/openrao/monitoring/Monitoring.java Outdated Show resolved Hide resolved
generic-monitoring/src/main/java/com/powsybl/openrao/monitoring/Monitoring.java Outdated Show resolved Hide resolved
generic-monitoring/src/main/java/com/powsybl/openrao/monitoring/Monitoring.java Outdated Show resolved Hide resolved
generic-monitoring/src/main/java/com/powsybl/openrao/monitoring/Monitoring.java Outdated Show resolved Hide resolved
generic-monitoring/src/main/java/com/powsybl/openrao/monitoring/Monitoring.java Outdated Show resolved Hide resolved
generic-monitoring/src/main/java/com/powsybl/openrao/monitoring/results/CnecResult.java Outdated Show resolved Hide resolved
generic-monitoring/src/main/java/com/powsybl/openrao/monitoring/Monitoring.java Outdated Show resolved Hide resolved
...ric-monitoring/src/main/java/com/powsybl/openrao/monitoring/AppliedNetworkActionsResult.java Outdated Show resolved Hide resolved
@benrejebmoh benrejebmoh changed the title WIP: draft version for generic monitoring (voltage + angle) generify voltage and angle monitoring Sep 3, 2024
@benrejebmoh benrejebmoh marked this pull request as ready for review September 3, 2024 09:41
@pet-mit pet-mit marked this pull request as draft September 3, 2024 12:39
pet-mit and others added 8 commits September 3, 2024 18:00
@pet-mit
RaoResult: store min and max voltage values for VoltageCnecs
58dcbe5 
Signed-off-by: Peter Mitri <[email protected]>
@benrejebmoh
refactoring monitoring: use min/max value as result of voltage monito…
2de32cd 
…ring

Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
resolve TODO's
0984b72 
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
Merge remote-tracking branch 'origin/main' into generic-monitoring
b50f26e
@benrejebmoh
replace monitoring module
9200380 
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
remove unused module from swe-cne-exporter pom.xml
a528791 
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
fix package change of cim crac creator
65d4c97 
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
resolve compile issues du to monitoring package replacing
26d2e49 
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh benrejebmoh requested a review from pet-mit September 12, 2024 11:27
Godelaine and others added 15 commits September 30, 2024 14:31
@Godelaine
fix timestamp
efff310
@benrejebmoh
changes after review
642b019 
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
Merge branch 'generic-monitoring' of https://github.com/powsybl/powsy…
ac2d3d8 
…bl-open-rao into generic-monitoring
@benrejebmoh
make failed monitoring result by state
a8da1a6 
Signed-off-by: benrejebmoh <[email protected]>
@Godelaine
Merge branch 'main' into generic-monitoring
eca8201
@benrejebmoh
remove DEEP_STUBS
49c56a8 
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
Merge branch 'generic-monitoring' of https://github.com/powsybl/powsy…
dbaf837 
…bl-open-rao into generic-monitoring
@Godelaine
review getFlow
a476d92 
Signed-off-by: Godelaine de Montmorillon <[email protected]>
@benrejebmoh
add unit tests for voltage/angle monitoring to cover the case where t…
1d912ba 
…he is a non valid contingency while monitoring a state

Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
Merge remote-tracking branch 'origin/generic-monitoring' into generic…
79652f7 
…-monitoring
@benrejebmoh
enhance coverage of RaoResultWithVoltageMonitoring
8a4942c 
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
save changes
92c8c97 
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
enhance coverage for monitoring
6ec443b 
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
enhance coverage for monitoring
9bcb8c9 
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
enhance coverage for monitoring
6a752d5 
Signed-off-by: benrejebmoh <[email protected]>
@bqth29 bqth29 added the breaking-change Changes could break users' code label Oct 7, 2024
Godelaine and others added 9 commits October 8, 2024 16:13
@Godelaine
fix bug when monitoredSide = side.Two
481a994 
Signed-off-by: Godelaine de Montmorillon <[email protected]>
@benrejebmoh
wip docs, commit to save changes
5b1ffd8 
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
Merge branch 'generic-monitoring' of https://github.com/powsybl/powsy…
8602edf 
…bl-open-rao into generic-monitoring
@benrejebmoh
replace separate angle/voltage monitoring documentation by a common o…
95fb313 
…ne after merging these two modules

Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
Merge remote-tracking branch 'origin/main' into generic-monitoring
c3ba2e3 
# Conflicts:
#	data/crac/crac-impl/src/test/java/com/powsybl/openrao/data/cracimpl/CracImplTest.java
#	data/result-exporter/swe-cne-exporter/src/test/java/com/powsybl/openrao/data/swecneexporter/SweCneDivergentAngleMonitoringTest.java
@benrejebmoh
merge with main branch manually
d422ff5 
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
documentation: replace references to legacy angle/voltage monitoring …
f391fe7 
…modules in different castor docs by reference to the new common module

Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
documentation: remove toctree from monitoring, + minor adjustments
780cb26 
Signed-off-by: benrejebmoh <[email protected]>
@benrejebmoh
documentation: update monitoring java-api in swe-cne output
7ad40b4 
Signed-off-by: benrejebmoh <[email protected]>
@Godelaine Godelaine merged commit 71b6260 into main Oct 10, 2024
10 checks passed
@Godelaine Godelaine deleted the generic-monitoring branch October 10, 2024 13:31
@Godelaine Godelaine mentioned this pull request Nov 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Godelaine Godelaine Godelaine approved these changes

@pet-mit pet-mit Awaiting requested review from pet-mit

Assignees
No one assigned
Labels
breaking-change Changes could break users' code PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge voltage & angle monitoring algorithms
4 participants
@benrejebmoh @pet-mit @Godelaine @bqth29