Fix OFCC triggered after any outage #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Bouquet <[email protected]>
bqth29
added
bug
Signed-off-by: Thomas Bouquet <[email protected]>
phiedw
reviewed
Jul 5, 2024
| @@ -249,7 +249,7 @@ public Set<NetworkAction> getActivatedNetworkActions() { | |||
| TopoAutomatonSimulationResult simulateTopologicalAutomatons(State automatonState, Network network, PrePerimeterSensitivityAnalysis preAutoPstOptimizationSensitivityAnalysis) { | |||
| // -- Apply network actions | |||
| // -- First get forced network actions | |||
| Set<FlowCnec> flowCnecs = crac.getFlowCnecs(); | |||
| Set<FlowCnec> flowCnecs = crac.getFlowCnecs(automatonState); | |||
There was a problem hiding this comment.
should we also check the curative cnecs on the same contingency?
There was a problem hiding this comment.
It is a good question... I would say no, but still have to check
There was a problem hiding this comment.
preparing for a release this afternoon or tomorrow morning, shall we include this fix?
pet-mit
added
the
next-release
pet-mit
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
A bug was reported from the SWE CC process where an OnFlowConstraintInCountry auto remedial action with no contingency defined was systematically triggered after all outages whereas only some of them were actually creating an overload in the given country.
What is the new behavior (if this is a feature change)?
The CNECs retrieved in the automaton simulator were not filtered on the state so this was corrected. Two Cucumber tests were added (one for ARA one for CRA) to ensure the problem is fixed.