fix bug on 2P Global Optimization with PST modeled as APPROXIMATED_INTEGERS
#1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBelthle
added
bug
MartinBelthle
changed the title
approximated_integersAPPROXIMATED_INTEGERS
MartinBelthle
force-pushed
the
improve-relative-ranges-handling
branch
from
d378fa5 to
34755b4
Compare
MartinBelthle
changed the title
APPROXIMATED_INTEGERSAPPROXIMATED_INTEGERS
phiedw
previously approved these changes
Jun 27, 2024
MartinBelthle
force-pushed
the
improve-relative-ranges-handling
branch
2 times, most recently
from
4328de8 to
2c30021
Compare
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
Signed-off-by: belthlemar <[email protected]>
MartinBelthle
force-pushed
the
improve-relative-ranges-handling
branch
from
2c30021 to
a321ab1
Compare
phiedw
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The problem only occurs with the following conditions:
For our scenario, we are going to consider that the PST has a relative limit of [-10, 0] and is at tap 5 initially.
It so, its curative limits are wrongly bounded to [-5, 5] because it considers that the tap 5 is fixed and it can only move compare to this value.
What is the new behavior ?
In the same scenario, the previous constraint does not exist anymore so the PST curative limits only depend on the preventive tap which evolves through the MIP.
Does this PR introduce a breaking change or deprecate an API?