Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve some TODOs #1063

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Resolve some TODOs #1063

merged 4 commits into from
Jul 5, 2024

Conversation

pet-mit
Copy link
Collaborator

@pet-mit pet-mit commented Jun 24, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Resolve some minor TODOs in the code

@pet-mit
Resolve some TODOs
61ba4a7 
Signed-off-by: Peter Mitri <[email protected]>
@pet-mit pet-mit requested a review from phiedw June 24, 2024 10:14
pet-mit added 2 commits June 24, 2024 12:16
@pet-mit
checkstyle
515571c 
Signed-off-by: Peter Mitri <[email protected]>
@pet-mit
fix test
33e679e 
Signed-off-by: Peter Mitri <[email protected]>
@pet-mit pet-mit added the PR: waiting-for-review This PR is waiting to be reviewed label Jun 24, 2024
phiedw
phiedw previously approved these changes Jul 5, 2024
View reviewed changes
@pet-mit pet-mit merged commit 9cf4288 into main Jul 5, 2024
10 checks passed
@pet-mit pet-mit deleted the resolve_todos branch July 5, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phiedw phiedw phiedw approved these changes

Assignees
No one assigned
Labels
PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pet-mit @phiedw