Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace rao range action apply by core action modification #1032

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Replace rao range action apply by core action modification #1032

merged 5 commits into from
Jul 22, 2024

Conversation

pjeanmarie
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@pjeanmarie pjeanmarie requested a review from obrix June 4, 2024 15:02
@pjeanmarie pjeanmarie linked an issue Jun 4, 2024 that may be closed by this pull request
In RAO: replace RAO ElementaryAction by Core NetworkModification/Security Action, In Core: Extract Action from security analysis and link them to NetworkModification #880
Closed
@pjeanmarie pjeanmarie changed the title Replace rao range action apply by core action modification WIP: Replace rao range action apply by core action modification Jun 4, 2024
@pjeanmarie pjeanmarie added PR : pending-for-dependency-release This PR can't be merged until one dependency is updated PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) labels Jun 5, 2024
@pjeanmarie
Copy link
Member Author

pjeanmarie commented Jun 5, 2024 •
edited
Loading

Do not merge: Need next core version (6.4.0), then pom need to be updated (6.4.0-SNAPSHOT -> 6.4.0) and changes on CI files need to be removed.

-> removed

@pjeanmarie pjeanmarie removed the PR : dont-merge-before-other PR mustn't be merged before another (referenced in the description or in the comments) label Jun 5, 2024
@pjeanmarie pjeanmarie changed the title WIP: Replace rao range action apply by core action modification Replace rao range action apply by core action modification Jun 5, 2024
@pjeanmarie pjeanmarie force-pushed the replace_rao_range_action_apply_by_core_action_modification branch 2 times, most recently from 9a4f957 to 932a510 Compare June 7, 2024 15:56
@pjeanmarie pjeanmarie added the PR: waiting-for-review This PR is waiting to be reviewed label Jul 4, 2024
@pjeanmarie pjeanmarie force-pushed the replace_rao_range_action_apply_by_core_action_modification branch 2 times, most recently from 45097c9 to 5085034 Compare July 4, 2024 09:30
@pjeanmarie pjeanmarie force-pushed the replace_rao_range_action_apply_by_core_action_modification branch 2 times, most recently from 64cfff7 to ca5b0ee Compare July 11, 2024 16:28
@pjeanmarie pjeanmarie removed the PR : pending-for-dependency-release This PR can't be merged until one dependency is updated label Jul 11, 2024
@pet-mit
Copy link
Collaborator

pet-mit commented Jul 12, 2024

@pjeanmarie please fix the DCO issue

@pet-mit pet-mit added next-release This issue or pull request should be resolved before next release PR: waiting-for-correction This PR is waiting to be corrected by its author and removed PR: waiting-for-review This PR is waiting to be reviewed labels Jul 12, 2024
Pauline Jean-Marie added 4 commits July 15, 2024 10:15
@pjeanmarie pjeanmarie force-pushed the replace_rao_range_action_apply_by_core_action_modification branch from 4f47cc6 to 941e759 Compare July 15, 2024 08:16
@pjeanmarie pjeanmarie requested a review from pet-mit July 15, 2024 14:12
obrix
obrix approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@obrix obrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, just a small comment.

data/crac/crac-impl/src/test/java/com/powsybl/openrao/data/cracimpl/PstRangeActionImplTest.java Show resolved Hide resolved
@pjeanmarie
Copy link
Member Author

pjeanmarie commented Jul 22, 2024 •
edited
Loading

@obrix @pet-mit I think there is no correction needed from my side but correct me if I am wrong.

@pet-mit pet-mit merged commit be7d4f2 into main Jul 22, 2024
10 checks passed
@pet-mit pet-mit deleted the replace_rao_range_action_apply_by_core_action_modification branch July 22, 2024 17:14
@pjeanmarie pjeanmarie linked an issue Aug 5, 2024 that may be closed by this pull request
Use powsybl-core's network modifications inside RangeAction implementations #1019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pet-mit pet-mit pet-mit approved these changes

@obrix obrix obrix approved these changes

Assignees
No one assigned
Labels
next-release This issue or pull request should be resolved before next release PR: waiting-for-correction This PR is waiting to be corrected by its author
Projects
None yet
Milestone
No milestone
3 participants
@pjeanmarie @pet-mit @obrix