Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RA group importer #1018

Merged
merged 2 commits into from
May 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ private Set<String> createRemedialActionGroups() {
}

NetworkAction refNetworkAction = crac.getNetworkAction(refRemedialActionDependency.remedialAction());
if (refRemedialActionDependency.remedialAction() == null) {
if (refNetworkAction == null) {
standaloneRasImplicatedIntoAGroup.addAll(dependingEnabledRemedialActions.stream().map(RemedialActionDependency::remedialAction).collect(Collectors.toSet()));
throw new OpenRaoImportException(ImportStatus.INCONSISTENCY_IN_DATA, "Remedial action group " + remedialActionGroup.mrid() + " will not be imported because the remedial action " + refRemedialActionDependency.remedialAction() + " does not exist or not imported. All RA's depending in that group will be ignored: " + printRaIds(dependingEnabledRemedialActions));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,4 +131,10 @@ private boolean hasTopologicalAction(Set<ElementaryAction> elementaryActions, St
.anyMatch(action -> ((TopologicalAction) action).getNetworkElement().getId().equals(elementId) && ((TopologicalAction) action).getActionType().equals(actionType));
}

@Test
void testImportRemedialActionGroupFromInvalidTopologyAction() {
CsaProfileCracCreationContext cracCreationContext = getCsaCracCreationContext("/profiles/remedialactions/RemedialActionGroupFromInvalidTopologyAction.zip", NETWORK);
assertTrue(cracCreationContext.getCrac().getNetworkActions().isEmpty());
}

}
Binary file not shown.
Loading