Add a border attribute to cnecs #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Edwards <[email protected]>
|
Documentation needs to be added. |
|
The csa importer could probably be updated as well to start using this. |
Signed-off-by: Philippe Edwards <[email protected]>
…border Signed-off-by: Philippe Edwards <[email protected]>
OpenSuze
approved these changes
May 24, 2024
Comment on lines
+25
to
+26
| protected final String operator; | ||
| protected final String border; |
bqth29
approved these changes
May 24, 2024
MartinBelthle
pushed a commit
that referenced
this pull request
May 28, 2024
* added border to all cnecs and json serializers/deserializers Signed-off-by: Philippe Edwards <[email protected] Signed-off-by: belthlemar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
Cnecs do not have a border attribute
What is the new behavior (if this is a feature change)?
They now do (FlowCnecs, VoltageCnecs and AngleCnecs)
Does this PR introduce a breaking change or deprecate an API?
What changes might users need to make in their application due to this PR? (migration steps)
They may now add adapt importers to add the border information if they so wish.
Other information:
This is done for the cse swa process, where the dichotomy algorithm needs to know to which border each cnec belongs to, to know where to do counter trading.