Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CIM Angle CNEC creation #1010

Merged
merged 3 commits into from
May 24, 2024
Merged

Fix CIM Angle CNEC creation #1010

merged 3 commits into from
May 24, 2024

Conversation

pet-mit
Copy link
Collaborator

@pet-mit pet-mit commented May 13, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

When importing an angle CNEC from CIM CRAC, two thresholds are created:

  • max = quantity read in the CIM
  • min = -quantity

What is the new behavior (if this is a feature change)?
The expected behavior is to only set max=quantity (the user can define another AdditionalConstraint_Series with inverted exporting & imported elements if they want to set a min)

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Peter Mitri <[email protected]>
@pet-mit pet-mit added bug Something isn't working PR: waiting-for-review This PR is waiting to be reviewed next-release This issue or pull request should be resolved before next release labels May 13, 2024
Signed-off-by: Peter Mitri <[email protected]>
@pet-mit pet-mit requested a review from murgeyseb May 13, 2024 14:01
@phiedw phiedw removed the PR: waiting-for-review This PR is waiting to be reviewed label May 24, 2024
@phiedw phiedw merged commit bcdb8af into main May 24, 2024
9 checks passed
MartinBelthle pushed a commit that referenced this pull request May 28, 2024
* Fix CIM Angle CNEC creation

Signed-off-by: Peter Mitri <[email protected]
Signed-off-by: belthlemar <[email protected]>
@pet-mit pet-mit deleted the fix_swe_angle_cnec branch June 20, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next-release This issue or pull request should be resolved before next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants