Fix bug injection setpoint shunt compensator can be applied #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pet-mit
requested changes
May 7, 2024
| @@ -163,6 +163,17 @@ void applyOnShuntCompensator() { | |||
| assertEquals(2., network.getShuntCompensator("SC1").getSectionCount(), 1e-3); | |||
| } | |||
|
|
|||
| @Test | |||
| void canBeAppliedOnShuntCompensator() { | |||
There was a problem hiding this comment.
good catch. please add a test with setpoint = 2 (canBeApplied = true) and setpoint = 1 (canBeApplied = true)
|
please fill PR description |
It change the behavior but it is a bug fix, so is it a breaking change? |
pjeanmarie
force-pushed
the
fix_bug_injection_setpoint_shunt_compensator_can_be_applied
branch
from
90f5b02 to
bd3ca0e
Compare
added 2 commits
May 13, 2024 13:45
Signed-off-by: Pauline Jean-Marie <[email protected]>
…be inferior to the max Signed-off-by: Pauline Jean-Marie <[email protected]>
pjeanmarie
force-pushed
the
fix_bug_injection_setpoint_shunt_compensator_can_be_applied
branch
from
bd3ca0e to
c11472a
Compare
no, not a breaking change |
pet-mit
approved these changes
May 13, 2024
pet-mit
deleted the
fix_bug_injection_setpoint_shunt_compensator_can_be_applied
branch
MartinBelthle
pushed a commit
that referenced
this pull request
May 28, 2024
Signed-off-by: belthlemar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Injection set point on shunt compensator cannot be applied (called by network action apply) if the setpoint is equal or below the max section count of the shunt compensator.
What is the new behavior (if this is a feature change)?
Injection set point on shunt compensator cannot be applied (called by network action apply) if the setpoint is strictly above the max section count of the shunt compensator.
Does this PR introduce a breaking change or deprecate an API?