-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/upgrade powsybl core to 4.10.1 #55
Open
armic-artelys
wants to merge
7
commits into
main
Choose a base branch
from
feature/upgrade_powsybl_core_to_4.10.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: amichaut <[email protected]>
… locale language is fr. Signed-off-by: amichaut <[email protected]>
…cale language is fr. Signed-off-by: amichaut <[email protected]>
Signed-off-by: amichaut <[email protected]>
…nal API of PlatformConfig. Signed-off-by: amichaut <[email protected]>
Signed-off-by: amichaut <[email protected]>
Signed-off-by: amichaut <[email protected]>
armic-artelys
force-pushed
the
feature/upgrade_powsybl_core_to_4.10.1
branch
from
September 20, 2022 10:45
69738d6
to
9d11bdc
Compare
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
I added @berthaultval as a rewiever |
miovd
added
PR: do-not-merge
PR: waiting-for-info-reviewer
and removed
PR: do-not-merge
labels
Sep 27, 2022
marifunf
reviewed
Oct 11, 2022
metrix-mapping/src/test/java/com/powsybl/metrix/mapping/TimeSeriesDslLoaderTest.java
Show resolved
Hide resolved
marifunf
reviewed
Oct 11, 2022
metrix-mapping/src/test/java/com/powsybl/metrix/mapping/TimeSeriesDslLoaderTest.java
Show resolved
Hide resolved
marifunf
reviewed
Oct 11, 2022
metrix-mapping/src/test/java/com/powsybl/metrix/mapping/TimeSeriesMapperCheckerTest.java
Show resolved
Hide resolved
marifunf
reviewed
Oct 11, 2022
metrix-mapping/src/test/java/com/powsybl/metrix/mapping/TimeSeriesProvideTsTest.java
Show resolved
Hide resolved
marifunf
reviewed
Oct 11, 2022
metrix-mapping/src/test/java/com/powsybl/metrix/mapping/TimeSeriesProvideTsTest.java
Show resolved
Hide resolved
armic-artelys
added a commit
that referenced
this pull request
Oct 11, 2022
…c calls to TestUtil#normalizeLineSeparator
marifunf
pushed a commit
that referenced
this pull request
Dec 8, 2022
…c calls to TestUtil#normalizeLineSeparator
marifunf
added
PR: do-not-merge
and removed
PR: waiting-for-info-reviewer
PR: waiting-for-review
labels
Dec 9, 2022
marifunf
pushed a commit
that referenced
this pull request
Apr 18, 2023
…c calls to TestUtil#normalizeLineSeparator
marifunf
pushed a commit
that referenced
this pull request
Apr 18, 2023
…c calls to TestUtil#normalizeLineSeparator Signed-off-by: marifunf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR upgrades the powsybl-metrix code to run with the latest powsybl-core available version (4.10.1).
Main changes are the following:
\n
UNIX line-break character. Now tests run both on Linux and Windows, easing the work of developers that run tests on Windows.What is the current behavior? (You can also link to an open issue here)
Currently, powsybl-metrix depends on the powsybl-core libraries with version 4.7.0.
What is the new behavior (if this is a feature change)?
Now, powsybl-metrix will depend on powsybl-core, version 4.10.1.
Other information:
I had to modify code in tests and also encoding of some test resources. I was aiming at allowing tests to be working from both Windows and Linux environments. I am not entirely sure that this complies with the maintainer vision, si this is merely a proposition from my part.