Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upgrade powsybl core to 4.10.1 #55

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

armic-artelys
Copy link
Contributor

@armic-artelys armic-artelys commented Sep 20, 2022

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit messages follow our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR upgrades the powsybl-metrix code to run with the latest powsybl-core available version (4.10.1).
Main changes are the following:

  • Adapt to the powsybl 4.9 module configuration optional fetching. If metrix configuration is not found, an IllegalStateException gets thrown.
  • Adapt to the package changes in powsybl 4.10.
  • Fix failures in tests caused by multi-lingual outputs. Added french possible outputs in the test resources along the english ones.
  • Fix failures in tests caused by the use of \n UNIX line-break character. Now tests run both on Linux and Windows, easing the work of developers that run tests on Windows.

What is the current behavior? (You can also link to an open issue here)
Currently, powsybl-metrix depends on the powsybl-core libraries with version 4.7.0.

What is the new behavior (if this is a feature change)?
Now, powsybl-metrix will depend on powsybl-core, version 4.10.1.

Other information:
I had to modify code in tests and also encoding of some test resources. I was aiming at allowing tests to be working from both Windows and Linux environments. I am not entirely sure that this complies with the maintainer vision, si this is merely a proposition from my part.

@armic-artelys armic-artelys force-pushed the feature/upgrade_powsybl_core_to_4.10.1 branch from 69738d6 to 9d11bdc Compare September 20, 2022 10:45
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@geleouet
Copy link

I added @berthaultval as a rewiever

armic-artelys added a commit that referenced this pull request Oct 11, 2022
…c calls to TestUtil#normalizeLineSeparator
marifunf pushed a commit that referenced this pull request Dec 8, 2022
…c calls to TestUtil#normalizeLineSeparator
marifunf pushed a commit that referenced this pull request Apr 18, 2023
…c calls to TestUtil#normalizeLineSeparator
marifunf pushed a commit that referenced this pull request Apr 18, 2023
…c calls to TestUtil#normalizeLineSeparator

Signed-off-by: marifunf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants