Fix potential NPE in MmapByteBufferService #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Rol <[email protected]>
olperr1
approved these changes
Nov 7, 2024
jeandemanged
reviewed
Nov 7, 2024
Comment on lines
128
to
129
| } catch (Exception e) { | ||
| LOGGER.trace(e.toString(), e); |
There was a problem hiding this comment.
Suggested change
| } catch (Exception e) { | |
| LOGGER.trace(e.toString(), e); | |
| } catch (IOException e) { | |
| throw new UncheckedIOException(e); |
There was a problem hiding this comment.
Ok for the IOException but we don't want to throw an exception if we fail to delete the file, just log it and return false
Signed-off-by: Nicolas Rol <[email protected]>
|
|
rolnico
added a commit
that referenced
this pull request
Nov 7, 2024
* fix potential NPE Signed-off-by: Nicolas Rol <[email protected]> * back to catching IOException Signed-off-by: Nicolas Rol <[email protected]> --------- Signed-off-by: Nicolas Rol <[email protected]> (cherry picked from commit 21929f8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
In
MmapByteBufferService.tryToDelete(),context.filecan be null, which will throw a NullPointerException when trying to delete the fileWhat is the new behavior (if this is a feature change)?
We now check first if
context.fileis null or notDoes this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: