Rework GitHub workflows #178

jeandemanged · 2024-10-15T17:50:11Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Refactor

What is the current behavior?

many workflows a bit complicated

What is the new behavior (if this is a feature change)?
Three workflows: Dev, Full, and Release.

Dev:

triggered on PRs or manually(workflow_dispatch) . If manual run, option to produce artifacts.
Java:
- 3 OSs: Windows, Linux(Ubuntu), macOS
- build and test on all 3 OSs
- Linux(Ubuntu) only: sonar.
C++:
- 3 OSs: Ubuntu, OL8, CentOS7
- build and test on all 3 OSs
- Linux(Ubuntu) only:
  - Sonar - coverage computed on reduced set of Metrix tests
  - Clang Tidy report on PR modified C++ sources

Note that earlier workflows were not running C++ builts when no C++ files modified. This behavior was NOT retained. Reason: it is confusing to see in GitHub PR the checks being required but not launched …

Full: Same as Dev CI, except:

triggered on protected branches and tags
C++:
- Linux(Ubuntu) only:
  - Sonar - coverage computed on complete set of Metrix tests
  - Clang Tidy report on all C++ sources

Release:

triggered on release creation
Java:
- Linux(Ubuntu) only: build, test, upload itools-metrix.zip
C++:
- 3 OSs: Ubuntu, OL8, CentOS7
- build, test, upload metrix-simulator-.zip

Does this PR introduce a breaking change or deprecate an API?

No

Other information:

Clang Tidy report job had issues which have been fixed.

Signed-off-by: Damien Jeandemange <[email protected]>

rolnico

Remember to delete the old files :)

rolnico · 2024-11-06T14:10:12Z

.github/workflows/release-ci.yml

+          echo "archive_path=$ARCHIVE_PATH" >> "$GITHUB_OUTPUT"
+
+      - name: Upload release package
+        uses: softprops/action-gh-release@v2


Suggested change

uses: softprops/action-gh-release@v2

uses: softprops/action-gh-release@e7a8f85e1c67a31e6ed99a94b41bd0b71bbee6b8 # v2.0.9

rolnico · 2024-11-06T14:10:20Z

.github/workflows/release-ci.yml

+          echo "archive_path=$ARCHIVE_PATH" >> "$GITHUB_OUTPUT"
+
+      - name: Upload release package
+        uses: softprops/action-gh-release@v2


Suggested change

uses: softprops/action-gh-release@v2

uses: softprops/action-gh-release@e7a8f85e1c67a31e6ed99a94b41bd0b71bbee6b8 # v2.0.9

rolnico · 2024-11-06T14:10:35Z

.github/workflows/release-ci.yml

+        run: ./mvnw --batch-mode package
+
+      - name: Upload release package
+        uses: softprops/action-gh-release@v2


Suggested change

uses: softprops/action-gh-release@v2

uses: softprops/action-gh-release@e7a8f85e1c67a31e6ed99a94b41bd0b71bbee6b8 # v2.0.9

rolnico · 2024-11-06T14:14:08Z

.github/workflows/release-ci.yml

+          echo "archive_path=$ARCHIVE_PATH" >> "$GITHUB_OUTPUT"
+
+      - name: Upload release package
+        uses: softprops/action-gh-release@v1


Suggested change

uses: softprops/action-gh-release@v1

uses: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844 # v1

rolnico · 2024-11-06T14:33:18Z

.github/workflows/dev-ci.yml

+name: Dev CI
+
+on:
+  workflow_dispatch:


I don't see the workflow_dispatch trigger on the action page yet, is it normal?

my understanding is that we have to wait that the PR is merged...

meanwhile it can be triggered by GitHub CLI using:

gh workflow run --ref=gh-workflows

See https://stackoverflow.com/a/67840292 and its most upvoted comment explaining the trick which I applied for Dev CI.

I re-ran it here: https://github.com/powsybl/powsybl-metrix/actions/runs/11706681139

rolnico · 2024-11-06T14:47:27Z

.github/workflows/full-ci.yml

@@ -0,0 +1,322 @@
+name: Full CI
+
+on:


Maybe add:

Suggested change

on:

on:

workflow_dispatch:

?

Signed-off-by: Damien Jeandemange <[email protected]>

sonarcloud · 2024-11-06T15:28:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-11-06T15:38:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

* try rework github workflows Signed-off-by: Damien Jeandemange <[email protected]> * try rework github workflows Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * wip Signed-off-by: Damien Jeandemange <[email protected]> * fix Signed-off-by: Damien Jeandemange <[email protected]> * use softprops/action-gh-release Signed-off-by: Damien Jeandemange <[email protected]> * fix Signed-off-by: Damien Jeandemange <[email protected]> --------- Signed-off-by: Damien Jeandemange <[email protected]> (cherry picked from commit dcb11db)

jeandemanged added 15 commits October 15, 2024 19:49

try rework github workflows

3adc7df

Signed-off-by: Damien Jeandemange <[email protected]>

try rework github workflows

e89e73d

Signed-off-by: Damien Jeandemange <[email protected]>

clang tidy

73a8181

Signed-off-by: Damien Jeandemange <[email protected]>

clang tidy

d450945

Signed-off-by: Damien Jeandemange <[email protected]>

clang tidy

fc6491b

Signed-off-by: Damien Jeandemange <[email protected]>

clang tidy

cf78812

Signed-off-by: Damien Jeandemange <[email protected]>

clang tidy

e90f5cd

Signed-off-by: Damien Jeandemange <[email protected]>

clang tidy

ba6aa9f

Signed-off-by: Damien Jeandemange <[email protected]>

artifacts

0f32175

Signed-off-by: Damien Jeandemange <[email protected]>

artifacts

c13fbf2

Signed-off-by: Damien Jeandemange <[email protected]>

artifacts

3067cb0

Signed-off-by: Damien Jeandemange <[email protected]>

artifacts

723273b

Signed-off-by: Damien Jeandemange <[email protected]>

wip

a9528ad

Signed-off-by: Damien Jeandemange <[email protected]>

fix

b1c03be

Signed-off-by: Damien Jeandemange <[email protected]>

Merge branch 'main' into gh-workflows

fbd0925

jeandemanged changed the title ~~[WIP] try rework github workflows~~ [WIP] Rework GitHub workflows Nov 6, 2024

use softprops/action-gh-release

82bb2fb

Signed-off-by: Damien Jeandemange <[email protected]>

jeandemanged changed the title ~~[WIP] Rework GitHub workflows~~ Rework GitHub workflows Nov 6, 2024

Merge branch 'main' into gh-workflows

fa69197

jeandemanged requested a review from rolnico November 6, 2024 13:40

rolnico requested changes Nov 6, 2024

View reviewed changes

fix

2b48cfc

Signed-off-by: Damien Jeandemange <[email protected]>

rolnico approved these changes Nov 7, 2024

View reviewed changes

rolnico merged commit dcb11db into main Nov 7, 2024
20 checks passed

rolnico deleted the gh-workflows branch November 7, 2024 13:38

jeandemanged linked an issue Nov 8, 2024 that may be closed by this pull request

Clang-Tidy job in CI does not work #114

Closed

rolnico mentioned this pull request Nov 8, 2024

Clang-Tidy job in CI does not work #114

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rework GitHub workflows #178

Rework GitHub workflows #178

jeandemanged commented Oct 15, 2024 •

edited

Loading

rolnico left a comment

rolnico Nov 6, 2024

rolnico Nov 6, 2024

rolnico Nov 6, 2024

rolnico Nov 6, 2024

rolnico Nov 6, 2024

jeandemanged Nov 6, 2024

rolnico Nov 6, 2024

sonarcloud bot commented Nov 6, 2024

sonarcloud bot commented Nov 6, 2024

	uses: softprops/action-gh-release@v2
	uses: softprops/action-gh-release@e7a8f85e1c67a31e6ed99a94b41bd0b71bbee6b8 # v2.0.9

	uses: softprops/action-gh-release@v1
	uses: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844 # v1

Rework GitHub workflows #178

Rework GitHub workflows #178

Conversation

jeandemanged commented Oct 15, 2024 • edited Loading

rolnico left a comment

Choose a reason for hiding this comment

rolnico Nov 6, 2024

Choose a reason for hiding this comment

rolnico Nov 6, 2024

Choose a reason for hiding this comment

rolnico Nov 6, 2024

Choose a reason for hiding this comment

rolnico Nov 6, 2024

Choose a reason for hiding this comment

rolnico Nov 6, 2024

Choose a reason for hiding this comment

jeandemanged Nov 6, 2024

Choose a reason for hiding this comment

rolnico Nov 6, 2024

Choose a reason for hiding this comment

sonarcloud bot commented Nov 6, 2024

Quality Gate passed

sonarcloud bot commented Nov 6, 2024

Quality Gate passed

jeandemanged commented Oct 15, 2024 •

edited

Loading