Fix CI (boost not avaible on github actions) #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sébastien LAIGRE <[email protected]>
sebalaig
force-pushed
the
fix-boost-missing
branch
from
fe0127a
to
4766aba
Compare
jsoref
reviewed
Feb 24, 2021
Signed-off-by: Sébastien LAIGRE <[email protected]>
sebalaig
force-pushed
the
fix-boost-missing
branch
15 times, most recently
from
7adefce
to
938325b
Compare
Signed-off-by: Sébastien LAIGRE <[email protected]>
sebalaig
force-pushed
the
fix-boost-missing
branch
from
938325b
to
bab5a35
Compare
sebalaig
changed the title
Signed-off-by: Mathieu BAGUE <[email protected]>
mathbagu
approved these changes
Feb 26, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
jsoref
reviewed
Feb 26, 2021
Comment on lines
+13
to
+17
| run: sudo apt install -y libboost-all-dev | ||
|
|
||
| - name: Install clang-tidy | ||
| run: | | ||
| sudo apt-get install -y clang-tidy-9 | ||
| sudo apt install -y clang-tidy-9 |
There was a problem hiding this comment.
At least last I checked, apt-get (and apt-cache) was (were) recommended for CI because apt didn't have a committed non-interactive mode, and it will spit out a warning when run in such conditions.
mathbagu
pushed a commit
that referenced
this pull request
Mar 10, 2021
Signed-off-by: Sébastien LAIGRE <[email protected]> Signed-off-by: Mathieu BAGUE <[email protected]>
sebalaig
added a commit
that referenced
this pull request
Mar 12, 2021
Signed-off-by: Sébastien LAIGRE <[email protected]> Signed-off-by: Mathieu BAGUE <[email protected]>
mathbagu
pushed a commit
that referenced
this pull request
Mar 18, 2021
Signed-off-by: Sébastien LAIGRE <[email protected]> Signed-off-by: Mathieu BAGUE <[email protected]>
mathbagu
pushed a commit
that referenced
this pull request
Apr 12, 2021
Signed-off-by: Sébastien LAIGRE <[email protected]> Signed-off-by: Mathieu BAGUE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sébastien LAIGRE [email protected]
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Boost is not available on CI environments provided by github actions (actions/runner-images#2667)
What is the current behavior? (You can also link to an open issue here)
CI is failing because boost is required and not available on environments
What is the new behavior (if this is a feature change)?
Boost is installed :
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)