Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump sqlite_async version to 0.9.0 #186

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

davidmartos96
Copy link
Contributor

Updates sqlite_async version in the package and in the demos, and it updates the drift demo with an up to date version.
Depends on powersync-ja/sqlite_async.dart#65

@mugikhan
Copy link
Contributor

mugikhan commented Oct 9, 2024

@davidmartos96 can you run melos prepare in the monorepo and ensure there are no errors when fetching these dependencies?

As noted in #160, the supabase-todolist-drift demo will fail to fetch it's dependencies when upgrading to sqlite_async v0.9.0. We have also not published drift_sqlite_async: ^0.2.0-alpha.1 and will fail on dependency resolution.

@davidmartos96
Copy link
Contributor Author

I did run melos bootstrap.
Errors are expected because powersync-ja/sqlite_async.dart#65 is not published yet.
We can mark as draft if you wish

@mugikhan
Copy link
Contributor

Hey @davidmartos96 I am unsure about the upgrade of the sqlite3 package as we haven't released our core extension with support for the upgraded version. Could you please run a melos prepare and ensure that you don't have any errors?

@davidmartos96
Copy link
Contributor Author

@mugikhan I believe the problem is because this hasn't been merged yet powersync-ja/sqlite3.dart#10

It adds compatibility with sqlite3 v2.4.6 on Web WASM which is the minimum version that supports web 1.0.0, required by sqlite_async 0.9.0

Copy link
Contributor

@mugikhan mugikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've merged the sqlite3.dart PR and I've run melos prepare locally and it succeeds with no errors.

@mugikhan mugikhan merged commit 4fda235 into powersync-ja:main Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants