Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support client_id and User-Agent #64

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Support client_id and User-Agent #64

merged 4 commits into from
Aug 26, 2024

Conversation

rkistner
Copy link
Contributor

  1. Support client_id parameter.
    1. This specifically affects write checkpoints (limits write checkpoints to a specific client, rather than just an user).
    2. The id is generated by the client and not sure on its own, so we still scope per user_id.
  2. Allow User-Agent and X-User-Agent headers.
    1. This allows us to identify which client is used.

Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: 44f907e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@powersync/service-core Minor
@powersync/service-image Minor
test-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rkistner rkistner marked this pull request as draft August 22, 2024 15:45
@rkistner rkistner marked this pull request as ready for review August 26, 2024 13:51
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rkistner rkistner merged commit 77743cc into main Aug 26, 2024
8 checks passed
@rkistner rkistner deleted the client-id branch August 26, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants