Redis streams native ids #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's nothing useful they can do with it anyway.
…acklog Will now report -1 any time a message comes directly from a specific channel. It is not possible for an arbitrary backend implementation to efficiently provide the `global_id` of messages fetched from channel-specific storage mechanisms.
Also probably improves performance by fetching full backlogs less often.
Subscribing from some future point is unnecessary and heavy to implement. See ae0d7cd#commitcomment-31541983
When client code tries to subscribe to a channel using a `last_id` that doesn't exist on that channel, we raise an exception. See ae0d7cd#commitcomment-31544627 for details.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates work on IDs into the Redis Streams implementation.