Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I made a breaking change: #8

Closed
jamestalmage opened this issue Nov 7, 2015 · 2 comments
Closed

I made a breaking change: #8

jamestalmage opened this issue Nov 7, 2015 · 2 comments

Comments

@jamestalmage
Copy link
Contributor

When I made this change, I thought I was modifying a private API.

Unfortunately AssertionVisitor is exposed publicly and used in babel-plugin-espower.

The only way this is a problem is if people have pinned to babel-plugin-espower@>=1.0.0 <1.1.0 (i.e. a Tilde Range)

It is probably worth releasing [email protected] that pins espower@>=1.0.0 <=1.2.0.

This probably has implications for empower as well.

@twada
Copy link
Member

twada commented Nov 7, 2015

@jamestalmage Oh nice catch. I should be more aware of argument ordering.
That was my mistake. So sorry.
Now working on 1.0.1 release.

twada added a commit that referenced this issue Nov 7, 2015
@twada
Copy link
Member

twada commented Nov 7, 2015

Released babel-plugin-espower 1.0.1. Thanks!

@twada twada closed this as completed Nov 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants