Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

made password input hidden and more clear #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kara-Zor-El
Copy link

when you input your password currently it shows the password in plaintext which isn't great.
What I did was make it so that it gives prompts for input and password
ex.

Please provide your AppleID
Apple ID: [email protected]
Please provide the password for [email protected]
Password: ********** 

the password is input but instead of displaying it for any passer by to see, it shows ***s' that is the length of the password

@powenn
Copy link
Owner

powenn commented Jan 25, 2022

when you input your password currently it shows the password in plaintext which isn't great.

What I did was make it so that it gives prompts for input and password

ex.


Please provide your AppleID

Apple ID: [email protected]

Please provide the password for [email protected]

Password: ********** 

the password is input but instead of displaying it for any passer by to see, it shows ***s' that is the length of the password

I like this idea,it would be a great improvement of this script,but I think password hiding is not necessary,in my opinion,password showing makes user can check that did they type wrong password,also all the saved account saved in saved.txt ...so the password is still visible ,actually I want to added the printf parts,for any questions,suggestions,welcome to discuss .

@powenn
Copy link
Owner

powenn commented Jan 25, 2022

Btw, I am thinking about to modify the script for a loop that can back to asking for options after install AltStore or ipa file

@Kara-Zor-El
Copy link
Author

I also had concerns about it storing the passwords in plain text but didnt know how to fix that. I understand the idea of verifying the password but if the password doesnt work they can always do it again (and it would be much easier if making the entire script in a loop)

@powenn
Copy link
Owner

powenn commented Jan 25, 2022

I also had concerns about it storing the passwords in plain text but didnt know how to fix that. I understand the idea of verifying the password but if the password doesnt work they can always do it again (and it would be much easier if making the entire script in a loop)

Thanks for your response, I will finding the solution for loop ,and I will retain this pull request before I decide it or password issues get solved

@Macleykun
Copy link
Contributor

I also had concerns about it storing the passwords in plain text but didnt know how to fix that. I understand the idea of verifying the password but if the password doesnt work they can always do it again (and it would be much easier if making the entire script in a loop)

Thanks for your response, I will finding the solution for loop ,and I will retain this pull request before I decide it or password issues get solved

heya :) ya have decided wheter or not to merge this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants