Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: killing descendants #2

Merged
merged 8 commits into from
Jul 24, 2023
Merged

fix: killing descendants #2

merged 8 commits into from
Jul 24, 2023

Conversation

saman3d
Copy link
Contributor

@saman3d saman3d commented Jul 21, 2023 •
edited
Loading

with this changes we are able to use go modules inside docker container. and we can handle TERMINATE and INTERRUPT signals to gracefully close watchers.

pouyanh
pouyanh requested changes Jul 24, 2023
View reviewed changes
Copy link
Owner

@pouyanh pouyanh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Main idea was perfect. Just had some comments on cleanup & readability

examples/hotreload/docker-compose.yml Outdated Show resolved Hide resolved
polywatch.go Outdated Show resolved Hide resolved
polywatch.go Outdated Show resolved Hide resolved
pw.example.yml Outdated Show resolved Hide resolved
examples/hotreload/api/.pw.yml Outdated Show resolved Hide resolved
@pouyanh pouyanh merged commit 93ff5a4 into pouyanh:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pouyanh pouyanh pouyanh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saman3d @pouyanh