Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ember Data canary ember-try scenario #202

Merged
merged 2 commits into from
Nov 11, 2017
Merged

Fix Ember Data canary ember-try scenario #202

merged 2 commits into from
Nov 11, 2017

Conversation

backspace
Copy link
Collaborator

No description provided.

@backspace backspace requested a review from jlami November 11, 2017 20:26
jlami
jlami approved these changes Nov 11, 2017
View reviewed changes
Copy link
Collaborator

@jlami jlami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! This seems to use ember-data 2.18.0-canary

If only there was a way to move away from bower for ember-source, but I guess the compile/package step is holding us back for that. The current setup will work for now. Thanks for your changes!

@backspace
Copy link
Collaborator Author

I don’t mind that much because we’re only needing to use it for tests, with no actual bower.json in the project 😆

@backspace backspace merged commit 2d76fd3 into master Nov 11, 2017
@jlami
Copy link
Collaborator

jlami commented Nov 11, 2017

Yeah, that is true. But I now @broerse would like to have no mention of bower at all 😉
But this will have to do for now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlami jlami jlami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@backspace @jlami