Dontsave hasmany #159
Merged
Dontsave hasmany #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2016
Closed
…cation reset doesn't erase previous settings
jlami
force-pushed
the
dontsave-hasmany
branch
from
514238c to
958ee06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes with pouchdb-community/relational-pouch#61
I added some new configuration options to enable specifying sync and async default values. Ember-pouch was still using sync as default, and ember has changed to async. And also to specify if this new feature of not saving the hasMany ids is globally enabled or not.
You can still specify it per relation with the option
dontsave.config.emberpouch.asyncconfig.emberpouch.dontsavehasmanyI also changed the way the
adapter.queryparses it's response, because it did not do this with relations in mind.The tests are also wrapped in async+hasmany modules, to be able to test all configuration options.