Skip to content

Commit

Permalink
Remove "Label when approved" workflow (apache#24704)
Browse files Browse the repository at this point in the history
The labelling workflow has proven to be far less useful than we
thought and some of the recent changes in selective checks made
it largely obsolete. The committers can still add "full tests needed"
label when they think it is needed and there is no need to label
the PRs automatically for that (or any other reason).

For quite a while this workflow is basically a useless noise.

(cherry picked from commit 359700a)
  • Loading branch information
potiuk committed Jun 29, 2022
1 parent 174ee47 commit 0d659c9
Show file tree
Hide file tree
Showing 28 changed files with 160 additions and 426 deletions.
1 change: 0 additions & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ tests export-ignore
Dockerfile.ci export-ignore

ISSUE_TRIAGE_PROCESS.rst export-ignore
PULL_REQUEST_WORKFLOW.rst export-ignore
STATIC_CODE_CHECKS.rst export-ignore
TESTING.rst export-ignore
LOCAL_VIRTUALENV.rst export-ignore
Expand Down
1 change: 0 additions & 1 deletion .github/actions/checks-action
Submodule checks-action deleted from 9f0287
1 change: 0 additions & 1 deletion .github/actions/label-when-approved-action
Submodule label-when-approved-action deleted from 0058d0
28 changes: 0 additions & 28 deletions .github/workflows/label_when_reviewed.yml

This file was deleted.

177 changes: 0 additions & 177 deletions .github/workflows/label_when_reviewed_workflow_run.yml

This file was deleted.

6 changes: 0 additions & 6 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
[submodule ".github/actions/get-workflow-origin"]
path = .github/actions/get-workflow-origin
url = https://github.com/potiuk/get-workflow-origin
[submodule ".github/actions/checks-action"]
path = .github/actions/checks-action
url = https://github.com/LouisBrunner/checks-action
[submodule ".github/actions/configure-aws-credentials"]
path = .github/actions/configure-aws-credentials
url = https://github.com/aws-actions/configure-aws-credentials
Expand All @@ -13,6 +10,3 @@
[submodule ".github/actions/github-push-action"]
path = .github/actions/github-push-action
url = https://github.com/ad-m/github-push-action
[submodule ".github/actions/label-when-approved-action"]
path = .github/actions/label-when-approved-action
url = https://github.com/TobKed/label-when-approved-action
6 changes: 0 additions & 6 deletions CI.rst
Original file line number Diff line number Diff line change
Expand Up @@ -426,12 +426,6 @@ CI, Production Images as well as base Python images that are also cached in the
Also for those builds we only execute Python tests if important files changed (so for example if it is
"no-code" change, no tests will be executed.

The workflow involved in Pull Requests review and approval is a bit more complex than simple workflows
in most of other projects because we've implemented some optimizations related to efficient use
of queue slots we share with other Apache Software Foundation projects. More details about it
can be found in `PULL_REQUEST_WORKFLOW.rst <PULL_REQUEST_WORKFLOW.rst>`_.


Direct Push/Merge Run
---------------------

Expand Down
27 changes: 0 additions & 27 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -360,33 +360,6 @@ Step 4: Prepare PR
PR guidelines described in `pull request guidelines <#pull-request-guidelines>`_.
Create Pull Request! Make yourself ready for the discussion!

5. Depending on "scope" of your changes, your Pull Request might go through one of few paths after approval.
We run some non-standard workflow with high degree of automation that allows us to optimize the usage
of queue slots in GitHub Actions. Our automated workflows determine the "scope" of changes in your PR
and send it through the right path:

* In case of a "no-code" change, approval will generate a comment that the PR can be merged and no
tests are needed. This is usually when the change modifies some non-documentation related RST
files (such as this file). No python tests are run and no CI images are built for such PR. Usually
it can be approved and merged few minutes after it is submitted (unless there is a big queue of jobs).

* In case of change involving python code changes or documentation changes, a subset of full test matrix
will be executed. This subset of tests perform relevant tests for single combination of python, backend
version and only builds one CI image and one PROD image. Here the scope of tests depends on the
scope of your changes:

* when your change does not change "core" of Airflow (Providers, CLI, WWW, Helm Chart) you will get the
comment that PR is likely ok to be merged without running "full matrix" of tests. However decision
for that is left to committer who approves your change. The committer might set a "full tests needed"
label for your PR and ask you to rebase your request or re-run all jobs. PRs with "full tests needed"
run full matrix of tests.

* when your change changes the "core" of Airflow you will get the comment that PR needs full tests and
the "full tests needed" label is set for your PR. Additional check is set that prevents from
accidental merging of the request until full matrix of tests succeeds for the PR.

More details about the PR workflow be found in `PULL_REQUEST_WORKFLOW.rst <PULL_REQUEST_WORKFLOW.rst>`_.


Step 5: Pass PR Review
----------------------
Expand Down
Loading

0 comments on commit 0d659c9

Please sign in to comment.