-
Notifications
You must be signed in to change notification settings - Fork 33
[OBS-405]Add setup command for EC2 installation #242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ready for final review, or still WIP?
Co-authored-by: Mark Gritter <[email protected]>
@mgritter This is ready for final review. |
return nil | ||
} | ||
|
||
func configureSystemdFiles(collectionId string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error messages here are all minimally informational to the end user. What are they supposed to do next?
Probably, contact the support email for most of them, but are there any that can be corrected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't think user can do anything. because lack of systemd is quite unfixable.
Co-authored-by: Mark Gritter <[email protected]>
Co-authored-by: Mark Gritter <[email protected]>
Why
What
postman-lc-agent setup
for installation in linux serversHow
setup
setupAgentForServer
->checkUserPermissions
->checkSystemdExists
->configureSystemdFiles
->enablePostmanAgent
->postChecks
func configureSystemdFiles
/etc/default
and/usr/lib/systemd/system
/etc/default/postman-lc-agent
and/usr/lib/systemd/system/postman-lc-agent.service
References
Test plan
TODO: Add more test cases